Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 93.89% 93.90%
=======================================
Files 67 67
Lines 4342 4348 +6
=======================================
+ Hits 4077 4083 +6
Misses 265 265 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eacharles
reviewed
Apr 28, 2026
Collaborator
eacharles
left a comment
eacharles
left a comment
There was a problem hiding this comment.
Would it make sense to use "-1" to mean all to avoid mixing types?
joezuntz
changed the title
Contributor
Author
|
I have updated to define constants in |
Contributor
Author
|
The only remaining failure here is the one that's independent of this that the other PR is intended to fix, as I understand it. |
eacharles
force-pushed
the
jz_any_bin_masked_summarizers
branch
from
99f3b28 to
c51e6f4
Compare
Collaborator
|
rebase to main to remove interactive tests. |
eacharles
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Solution Description (including issue #)
This allows passing the string "all" as the
selected_binconfiguration option to theNaiveStackSummarizerandPointEstHistMaskedSummarizerclasses. In that case any non-negative tomographic bin index objects will be selected, allowing us to run a non-tomographic analysis alongside a tomnographic one without duplicated data.Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added